Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my.pdfs error; updates from pdfannots #180

Closed
seanbreckenridge opened this issue Oct 28, 2021 · 0 comments · Fixed by #191
Closed

my.pdfs error; updates from pdfannots #180

seanbreckenridge opened this issue Oct 28, 2021 · 0 comments · Fixed by #191

Comments

@seanbreckenridge
Copy link
Contributor

pdfannots has made quite a lot of updates in the past few months, including Annotation and Document classes which replace the typical return values for the process_file, and some of the kwargs.

Currently just throws an error since the kwargs dont match the previous interface, but it also returns different data now

$ hpi query my.pdfs.annotations | jq '.[0]'
{
  "error": "Exception: process_file() got an unexpected keyword argument 'emit_progress'\n"
}

I would try and update this myself but not very used to working with annotations/pdfs and don't want to remove something which may be useful.

Also, even though there is a annotation class there, I think we should keep to a NT/Dataclass based one for cachew reasons. In addition, the fields there are nullable, which makes things a bit annoying.

This is why #179 is currently failing (also reminder that 3.6 macos CI is still broken here, I fixed it in that PR, but you'd probably have to do it again before thats merged in; will merge on top of it to get the changes)

karlicoss added a commit that referenced this issue Dec 19, 2021
undoes f5b47dd , tests work properly now

resolves #180
karlicoss added a commit that referenced this issue Dec 19, 2021
undoes f5b47dd , tests work properly now

resolves #180
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant