Fixes PolicyEngine#352

karenlilr · Jul 31, 2024 · 949d624 · 949d624
1 parent 1822c7d
commit 949d624
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 25 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -1,4 +1,3 @@
 - bump: minor
   changes:
-    added:
-    - New Brunswick Spouse or Common-law Partner base amount for the years 2022, 2023, and 2024; nb_spouse_and_common_law_partner_amount_credit to calculate the credit dynamically based on parameters; test cases; parameter configurations for base_amount and max_credit in the parameters file.
+    added: New Brunswick Spouse or Common-law Partner base amount.
diff --git a/.../gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml b/.../gov/provinces/nb/tax/income/credits/spouse_or_common_law_partner_amount/base_amount.yaml
@@ -6,7 +6,7 @@ values:
 metadata:
   unit: currency-CAD
   period: year
-  label: New Brunswick Spouse or Common-law Partner Base Amount
+  label: New Brunswick Spouse or Common-law Partner base Amount
   reference:
     - title: Worksheet for the 2022 New Brunswick Personal Tax Credits Return
       href: https://www.cchwebsites.com/content/pdf/tax_forms/ca/en/td1nbws_en.pdf#page=1

diff --git a/...common_law_partner_amount/max_credit.yaml → ...common_law_partner_amount/max_amount.yaml b/...common_law_partner_amount/max_credit.yaml → ...common_law_partner_amount/max_amount.yaml
@@ -1,12 +1,12 @@
-description: The New Brunswick spouse or common-law partner amount credit is calculated by taking into account the spouse's net income and comparing it to a base amount. The maximum credit is the highest amount that can be claimed as a credit.
+description: New Brunswick provides the following maximum spouse or common-law partner amount.
 values:
   2022-01-01: 9_186
   2023-01-01: 9_764
   2024-01-01: 10_223
 metadata:
   unit: currency-CAD
   period: year
-  label: New Brunswick Spouse or Common-law Partner Max Credit
+  label: New Brunswick Spouse or Common-law Partner max Credit
   reference:
     - title: Worksheet for the 2022 New Brunswick Personal Tax Credits Return
       href: https://www.cchwebsites.com/content/pdf/tax_forms/ca/en/td1nbws_en.pdf#page=1

diff --git a/...s/gov/provinces/nb/tax/income/credits/nb_spouse_and_common_law_partner_amount_credit.yaml b/...s/gov/provinces/nb/tax/income/credits/nb_spouse_and_common_law_partner_amount_credit.yaml
@@ -61,19 +61,5 @@
 
 
 parameters:
-  gov:
-    provinces:
-      nb:
-        tax:
-          income:
-            credits:
-              spouse_or_common_law_partner_amount:
-                base_amount:
-                  2022-01-01: 10_105
-                  2023-01-01: 10_741
-                  2024-01-01: 11_246
-                max_credit:
-                  2022-01-01: 9_186
-                  2023-01-01: 9_764
-                  2024-01-01: 10_223
+
 
diff --git a/...a/variables/gov/provinces/nb/tax/income/nb_spouse_and_common_law_partner_amount_credit.py b/...a/variables/gov/provinces/nb/tax/income/nb_spouse_and_common_law_partner_amount_credit.py
@@ -10,10 +10,8 @@ class nb_spouse_and_common_law_partner_amount_credit(Variable):
 
     def formula(household, period, parameters):
         p = parameters(period).gov.provinces.nb.tax.income.credits.spouse_or_common_law_partner_amount 
-        base_amount = p.base_amount  
-        max_credit = p.max_credit 
-
+
         spouse_income = add(household, period, ["spouse_income"])
-        reduced_amount = max_(base_amount - spouse_income, 0)  
-        return min(max_credit, reduced_amount)
+        reduced_amount = max_(p.base_amount - spouse_income, 0)  
+        return min(p.max_credit, reduced_amount)