-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionally support bigints and bignums #10
Comments
any interesting tests I come up with should be added to the test suite - see json-schema-org/JSON-Schema-Test-Suite#378 |
This should fix the issues I'm seeing on this smoker here -- http://www.cpantesters.org/cpan/report/c65fadbe-a2d4-11ea-9066-e374b0ba08e8 on my box:
let's see what it looks like on BinGOs's machine.. |
Different VM from the one that generated that report, but another 32bit Debian. Got a similar fail, so here is the output:
|
until I add bigint/bignum handling, I should just mark this specific test TODO if |
where ivsize < 8, the integer is being represented as a PV rather than an IV; where nvsize < 8, the float is being represented as a PV rather than an NV; if one of these comes through as a string, comparison with the other will fail on the types being different; if both come through as a string, the string comparison will fail. e.g. see GHI #10 and http://www.cpantesters.org/cpan/report/d9ff55c4-a13d-11ea-9066-e374b0ba08e8 http://www.cpantesters.org/cpan/report/a1898f1c-a097-11ea-b276-2fafcccccfd6 http://www.cpantesters.org/cpan/report/f6457db7-6bf7-1014-9edb-f53f8c633b70
- add infinite recursion detection - process properties in sorted order, for consistent ordering of results - mark a numeric comparison test as TODO on 32-bit machines (see GHI #10)
This is now complete, and with version 0.537, hopefully bug free. |
Cpanel::JSON::XS has a 'get_allow_bignum' option which inflates very large numbers into Math::BigInt or Math::BigFloat objects. If desired, we should support validating integers and numbers using this.
The text was updated successfully, but these errors were encountered: