Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2422 Add support of arm64 for image karatelabs/karate-chrome #2424

Merged
merged 11 commits into from
Jun 6, 2024

Conversation

jandry
Copy link
Contributor

@jandry jandry commented Oct 26, 2023

Description

Add support of arm64 for image karatelabs/karate-chrome

  • Relevant Issues : (compulsory)
  • Relevant PRs : this one
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@jandry jandry changed the base branch from master to develop October 26, 2023 20:09
Comment on lines +29 to +32
docker buildx build --platform linux/amd64 --cache-from=type=local,src=./target/docker --cache-to=type=local,dest=./target/docker -t karate-chrome -t karate-chrome:latest karate-docker/karate-chrome
# build karate-chromium docker image that includes karate fatjar + maven jars for convenience
# Both platform
docker buildx build --platform linux/amd64,linux/arm64 --cache-from=type=local,src=./target/docker --cache-to=type=local,dest=./target/docker -t karate-chromium karate-docker/karate-chromium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the build scripts in the tests have the docker buildx plugin configured?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope but I can't check if it's by default in gitlab run. It's maybe the case as it's a common use case now

@ptrthomas ptrthomas merged commit a6a5da8 into karatelabs:develop Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants