Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XmlUtils.java #1882

Closed
wants to merge 1 commit into from
Closed

Update XmlUtils.java #1882

wants to merge 1 commit into from

Conversation

PerJV
Copy link

@PerJV PerJV commented Jan 4, 2022

Ref. this discussion thread :
https://stackoverflow.com/questions/70569320/why-is-xmlns-added-by-karate
Setting
factory.setNamespaceAware(true);
will fix the issue with DocumentBuilder adding empty xmlns

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

  • Relevant Issues : (compulsory)
  • Relevant PRs : (optional)
  • Type of change :
    • New feature
    • [x ] Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

Ref. this discussion thread :
https://stackoverflow.com/questions/70569320/why-is-xmlns-added-by-karate
Setting 
factory.setNamespaceAware(true);
will fix the issue with DocumentBuilder  adding empty xmlns
@ptrthomas
Copy link
Member

the build failed, but most likely because it was expecting the old behavior
ideally we'd like a test to act as an example and validate the fix
I don't have time to dig in to this right now but thanks @PerJV this will at least help others to complete this fix !

image

@ptrthomas
Copy link
Member

closing as abandoned

@ptrthomas ptrthomas closed this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants