adds support for multiple mocks and service prefix #1570
Conversation
code blocks refactoring for better mainteinance
| File mock; | ||
|
|
||
| @Option(names = {"-m", "--mocks"}, split = ",", description = "one or more mock server files") |
There was a problem hiding this comment.
I'd like both --mock and --mocks to have the exact same behavior. can you check if this is possible with picocli
| @Option(names = {"-m", "--mocks"}, split = ",", description = "one or more mock server files") | ||
| List<File> mocks; | ||
|
|
||
| @Option(names = {"-P", "--prefix"}, description = "mock server prefix (contextPath)") |
There was a problem hiding this comment.
this is good. can you update the description to mock server path prefix (context-path)
| MockServer.Builder builder = MockServer | ||
| .feature(mock) | ||
| .featureFiles(features) | ||
| .prefix(prefix) |
There was a problem hiding this comment.
rename builder method to pathPrefix()
| @@ -263,12 +322,12 @@ public boolean methodIs(String name) { // TODO no more supporting array arg | |||
|
|
|||
| public boolean typeContains(String text) { | |||
| String contentType = LOCAL_REQUEST.get().getContentType(); | |||
| return contentType == null ? false : contentType.contains(text); | |||
| return contentType != null && contentType.contains(text); | |||
at a path defined by [pathPrefix] ref #1570
|
@ivangsa when you can review the last commit - do comment. I think being able to "mount" a mock on a URL path provides for some good flexibility |
looks more consistent now, but introduces an unnecesary breaking change for mocks that are already setting the prefix withouth first "/" leads to: maybe it's just a matter to adding the "/" if is missing inside |
|
@ivangsa ok I'll take care of that |
Description
adds support for multiple mocks and service prefix