Adding unit tests for Engine

[joelpramos]

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

• Relevant Issues : (compulsory)
• Relevant PRs : see Adding unit tests to test and reproduce several scenarios with readin… #1436 - note that PR is not merged and commits with solution are in the comments
• Type of change :
  • New feature
  • Bug fix for existing feature
  • Code quality improvement
  • Addition or Improvement of tests
  • Addition or Improvement of documentation

[joelpramos]

@ptrthomas got distracted with the debugger cause I stumbled across the problem so didn't have time to do the additional unit tests we talked in the other PR to try to find additional edge cases. These all pass with your fix.

[joelpramos]

Scenario: called feature with list of strings
  * def list = [ 'list1' ]
  * call read('call-arg-list-string.feature') list
  * match inside == 'got inside scenario'

call-arg-list-string.feature

Feature:

Background:

Scenario:
* print 'in scenario'
* match __arg == 'list1'
* def inside = 'got inside scenario'

@ptrthomas The called scenario is not called when it's a list of strings. If I change it to [ 'key': 'list1' ] it works.

Not sure if this is by design - I think the condition below skills the callFeature() method (basically checks that the values inside the list are a Map)

[ptrthomas]

@joelpramos yes by design: https://github.com/intuit/karate#data-driven-features

[joelpramos]

oh right cause it's mostly with tables good point - ok so I couldn't find anything else in the engine! this was the last thing I tried

[ptrthomas]

couldn't find anything else in the engine!

music to my ears. thanks 👍