Bugfix/call single in karate basejs from classpath

[joelpramos]

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

• Relevant Issues : Issue with Karate in an application packaged by Spring Boot #751
• Relevant PRs : (optional)
• Type of change :
  • New feature
  • Bug fix for existing feature
  • Code quality improvement
  • Addition or Improvement of tests
  • Addition or Improvement of documentation

[ptrthomas]

I merged this. also did a little more refactoring of Resource (just one constructor flow) and FileUtils

one request - can we avoid these 2 lines:

ClassLoader cl = this.classLoader != null ? this.classLoader : Resource.class.getClassLoader();
InputStream tempStream = cl.getResourceAsStream(relativePath.replace(FileUtils.CLASSPATH_COLON, ""));

if I'm not mistaken, the classLoader will never be null. also, the Path should always be a valid one. I hope that Files.newInputStream(path) should be sufficient. I also feel the classLoader does not need to kept in the Resource but maybe it can be useful in the future

[ptrthomas]

and just FYI - I just came across this: https://github.com/classgraph/classgraph

since this area has been so painful - and considering who knows what issues that Java 9 modules / jigsaw will bring - maybe we should just use this. wonder what you think @joelpramos

[joelpramos]

@ptrthomas for the first question - Files.newInputStream(path) is exactly where my problem with Spring Boot was. I left the null checks for classloader because I was only able to test in Windows (packaged JAR and via IntelliJ) and docker but couldn't test with other CI/CD tools / Mac.

Classgraph seems interesting ... I read through it and will probably be best to use to avoid such problems in the future as there might be other problems with other frameworks. I'll try to set it up during this week.

[ptrthomas]

@joelpramos

Files.newInputStream(path) is exactly where my problem with Spring Boot was.

ah ok, then fine - if it works it works. yes do look at Classgraph when you get time - an extra JAR dep is worth it