#1211 Standard delete Cookie behaviour does not work in Karate

[chaudharydeepak]

#1211 Standard delete Cookie behaviour does not work in Karate

We delete cookies by setting expiration from max-age. If cookie is getting expired via set-cookie header, modified code to include this while adding the cookie.

• Relevant Issues : bug(cookies): Standard delete Cookie behaviour does not work in Karate #1211 Standard delete Cookie behaviour does not work in Karate
• Type of change :
  • Bug fix for existing feature

[chaudharydeepak]

@ptrthomas - this possibly is the fix to delete cookies -

1. For Apache http client - while preparing the cookies for cookiestore, we set expiration based on max-age.

2. Additionally I noticed - seems if someone is removing cookie via set-cookie header, these cookies were not accounted for - included logic to read from header for set-cookie, then prepare the cookie and add to response.

Please let me know for any feedback -

included test cases as following -
@apache @mock-servlet-todo
Scenario: manually expire cookie by setting max-age to 0.
Given path 'search', 'cookies'
And cookie foo = {value:'bar', max-age:'0', path:'/search'}
And param domain = '.abc.com'
When method get
Then status 200
And match response == []

@apache @mock-servlet-todo
Scenario: max-age is -1, cookie should persist.
Given path 'search', 'cookies'
And cookie foo = {value:'bar', max-age:'-1', path:'/search'}
And param domain = '.abc.com'
When method get
Then status 200
And match response[0] contains { name: 'foo', value: 'bar', domain: '.abc.com' }

[ptrthomas]

and you had a question on how to check for what was sent - here is an example: https://github.com/intuit/karate/blob/master/karate-demo/src/test/java/demo/encoding/encoding.feature#L60

just FYI - there is configure setting in karate to convert all header names to lower-case, not on by default, example: https://github.com/intuit/karate/blob/master/karate-demo/src/test/java/demo/headers/content-type.feature

[ptrthomas]

@chaudharydeepak LGTM - were you planning any more changes ?

[chaudharydeepak]

@ptrthomas - no, I think we good, Thank you.

[ptrthomas]

@chaudharydeepak FYI: https://medium.com/intuit-engineering/develop-with-intuit-for-hacktoberfest-2020-8f29b70ff2b4

[chaudharydeepak]

@ptrthomas - Thank you for sharing this!

[chaudharydeepak]

@ptrthomas - quick update - I went ahead and filled the google form. Thank you for this amazing opportunity to collaborate!

@chaudharydeepak FYI: https://medium.com/intuit-engineering/develop-with-intuit-for-hacktoberfest-2020-8f29b70ff2b4