Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft Edge Chromium browser #1302

Merged

Conversation

sixdouglas
Copy link

@sixdouglas sixdouglas commented Oct 7, 2020

Description

Add support for Microsoft Edge Chromium browser.

  • I named the class EdgeChromium (com.intuit.karate.driver.microsoft.EdgeChromium) to be clear. But if the name is not what you expected, please tell me, I'll rename it.
  • The type keyword (com/intuit/karate/driver/DriverOptions.java:303) is also "edgeChromium"
  • I've also added Unit Tests but I'm not sure they will pass on the CI, specially if it runs on linux docker images, since this version of Edge browser in not available yet on Linux. (driver.demo.Demo01JavaRunner#testEdge, driver.screenshot.EdgeChromiumFullPageRunner, driver.screenshot.EdgePdfRunner)

PS: I've added .java-version to the .gitignore file because I'm using jenv MacOS tool to easily switch from a JDK to another. If you prefer me to remove this from the changes, just let me know.

  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

Copy link
Member

@ptrthomas ptrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ! guess what I think this can be the new msedge and we can just throw away the old one - if that sounds ok to you as well. if you can update the karate-core/README as well that would be great

@sixdouglas
Copy link
Author

Is it ok like this?

PS: I'll squash the commits in the end

@ptrthomas
Copy link
Member

yes this is fine

@sixdouglas sixdouglas force-pushed the feat/addSupportForMSEdgeChromium branch from 1e5a35b to 277b307 Compare October 7, 2020 08:08
@sixdouglas
Copy link
Author

This is the squashed version.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants