Improve docker file to allow for caching: Part 1 of many #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademariag
commented
Sep 10, 2023
| paths-ignore: | ||
| - 'docs/**' | ||
| workflow_run: |
There was a problem hiding this comment.
This was causing this workflow to checkout master instead of the PR we wanted to look at.
So we were pushing to master on every PR.
We should have checked out github.event.workflow_run.head_branch instead
ademariag
commented
Sep 10, 2023
| @@ -1,14 +1,30 @@ | |||
| --- | |||
| name: Docker Build and Push | |||
| on: | |||
| concurrency: | |||
There was a problem hiding this comment.
This prevents the workflow from running multiple times for the same code
ademariag
force-pushed
the
improve-build
branch
from
67f5272
to
c181925
Compare
ademariag
commented
Sep 10, 2023
| run: | | ||
| [ ${{ env.REF_NAME }} == "master" ] && tagname="latest" || tagname=${{ env.REF_NAME }} | ||
| docker run -t --rm kapicorp/kapitan:${tagname} --version | ||
| # - name: Test Dockerfile in current ref |
ademariag
force-pushed
the
improve-build
branch
from
fbba60c
to
4b8471a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Part 1 of a series of changes from https://github.com/ademariag/kapitan/tree/master/.github/workflows to improve the build process.
no functional changes expected
Done incrementally for easier review