fix(FEC-14071): thumbnail requests append height, width, ks too many times #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianbenjamin
requested review from
SivanA-Kaltura,
JonathanTGold,
MosheMaorKaltura and
semarche-kaltura
SivanA-Kaltura
requested changes
Jul 29, 2024
MosheMaorKaltura
approved these changes
Aug 7, 2024
SivanA-Kaltura
approved these changes
Aug 7, 2024
5 tasks
lianbenjamin
added a commit
to kaltura/kaltura-player-js
that referenced
this pull request
Aug 11, 2024
…times (#830) ### Description of the Changes bugfix **Issue:** when building `poster` and `sprite` URLs, we are using the `poster` as the base url and then appending params to it (height, width, ks). But, when poster has already been manipulated and we try to build it again, we re-append the params. **Fix:** use `rawThumbnailUrl` as the base url to build the urls. related PR: kaltura/playkit-js-providers#243 #### Resolves FEC-14071
lianbenjamin
added a commit
to kaltura/playkit-js-related
that referenced
this pull request
Aug 11, 2024
…times (#67) ### Description of the Changes align related with changes in `updateKalturaPoster` API. **related PRs:** kaltura/playkit-js-providers#243 kaltura/kaltura-player-js#830 ### CheckLists - [ ] changes have been done against master branch, and PR does not conflict - [ ] new unit / functional tests have been added (whenever applicable) - [ ] test are passing in local environment - [ ] Travis tests are passing (or test results are not worse than on master branch :)) - [ ] Docs have been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
bugfix
Issue:
when building
posterandspriteURLs, we are using theposteras the base url and then appending params to it (height, width, ks). But, whenposterhas already been manipulated and we try to build it again, we re-append the params.Fix:
add a new field to the media config sources object, named
rawThumbnailUrlwhich holds the raw url and can be used as the base url when buildingposterandsprite, instead of using the (manipulated)poster.related PR: kaltura/kaltura-player-js#830
Resolves FEC-14071