FEM-2502 AndroidX migration + ExoPlayer upgrade #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GouravSna
commented
May 29, 2019
GouravSna
commented
- ExoPlayer upgraded to 2.10.1
- Decoder reusability on change media (setForegroundMode())
- Support library migrated to AndroidX.
- Upgraded gson to 2.8.5 - Upgraded okhttp to 3.14.2 - Upgraded ExoPlayer to 2.10.1
- Refactored MediaPlayerWrapper
- Keeping the old file for the track.
- Added CustomMediaCodecRenderer
- ADAPTIVE support having -1 value is not supported in Exoplayer now, so changed the logic accordingly.
- Now the isAdaptiveTrack is being analysed based on the flag present in the track. - Removed the restriction of 5Gbps track. Logic is solely dependent on exoplayer now.
- Code cleanup
Relying on Exoplayer for track selection
# Conflicts: # playkit/build.gradle
noamtamim
suggested changes
Jul 15, 2019
playkit/src/main/java/com/kaltura/playkit/player/PKExternalSubtitle.java
Show resolved
Hide resolved
playkit/src/main/java/com/kaltura/playkit/player/PKExternalSubtitle.java
Show resolved
Hide resolved
noamtamim
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.