Fix to issue #104-#105, removed maptools dependency, new testing suite #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(from now on future mainFunction changes will be separate)
testing. Todo: clean up testing files so that they are only stored in _snaps Errors: few errors in testing larger supporting functions
suncalc::getSunlightTimes, times seem to differ by about a minute, Todo: run testing suite on new sunrise and sunset times
DESCRIPTION file changed to remove direct imports, TODO: remove sp dependencies in other packages
Upper for feeding and flight but using the right distThresh) Seems to have greatly increased the number of data points in consecEdges for feeding and decreased for flight (to be expected) However, the greatest change is that calcSRI for feeding now returns higher values, but the values for calcSRI in flight are quite small (need confirmation) Test files have both versions (broken and fixed)
Seemed to have been from making an artificial data.table from dataset SEE: points_to_edgelist_helper line 91 "timestamps <- dataset[,c(timestampCol, idCol, "timegroup")]"
Tests now use temporary files to store data Data frame files are now correctly named after the data frame they store Data is stored in tests/testthat/_snaps Files which differ from tests will have .new attatched and be stored in tests/testthat/_snaps
Removed ground_speed requirement in getEdges by only requiring column if either speedThresh is set. Changed ground_speed to be a explicit declared parameter named speedCol speedCol defaults to "ground_speed" and is passed to filterLocs roostPolygons now defaults to NULL
roostBuffer in getEdges now accepts NULL convertAndBuffer may throw an error if passed NULL as a distance, so roostPolygons are only buffered if roostbuffer is not NULL
ryannguyen6392
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to getEdges and get_roosts_df to fix issues and address direct dependencies.
spatsoc seems to be dealing with the issue ropensci/spatsoc#50, so hopefully the error should go away soon.
This testing branch pulled the latest version of the testing suite, so I think it should come with, but I'll have to see if there are any extra files that I didn't want in the main package.
Hopefully first of many PRs to address the issues and such!