Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #14 #20

Merged
merged 3 commits into from
Jul 9, 2022
Merged

Closes #14 #20

merged 3 commits into from
Jul 9, 2022

Conversation

i-m-aditya
Copy link
Contributor

Use mulmod over mul & div

kadenzipfel
kadenzipfel requested changes Jul 8, 2022
View reviewed changes
Copy link
Owner

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super well done 👏 just a couple requests to make sure everything is organized properly:

  • let's put this in the gas-golfing directory since it's quite specific
  • can you please add a link to this page in the readme

gas-saving-patterns/using-mulmod-over-mul&div.md Outdated Show resolved Hide resolved
kadenzipfel
kadenzipfel approved these changes Jul 9, 2022
View reviewed changes
Copy link
Owner

@kadenzipfel kadenzipfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kadenzipfel kadenzipfel merged commit be92351 into kadenzipfel:main Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadenzipfel kadenzipfel kadenzipfel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@i-m-aditya @kadenzipfel