Re-enable etcd endpoint auto-sync #8675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing this in 002e6c4 regressed control-plane-only nodes, as we rely on the etcd client to update its endpoint list internally so that we can use it to sync the load-balancer address list. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
johnatasr
approved these changes
Oct 18, 2023
dereknola
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Re-enable etcd endpoint auto-sync
Removing this in 002e6c4 regressed control-plane-only nodes, as we rely on the etcd client to update its endpoint list internally so that we can use it to sync the load-balancer address list.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments