Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cluster reset from non bootstrap nodes on snapshot restore e2e test #8292

Merged

Conversation

vitorsavian
Copy link
Member

Proposed Changes

Resets all cluster members in the test

Types of Changes

Test

Verification

go test -timeout=15m ./tests/e2e/snapshotrestore/... -run E2E

Testing

Linked Issues

User-Facing Change


Further Comments

…test

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner September 4, 2023 14:35
Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cae8b2b) 44.66% compared to head (1aaa770) 51.58%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8292      +/-   ##
==========================================
+ Coverage   44.66%   51.58%   +6.91%     
==========================================
  Files         143      143              
  Lines       14746    15229     +483     
==========================================
+ Hits         6587     7856    +1269     
+ Misses       7119     6159     -960     
- Partials     1040     1214     +174     
Flag Coverage Δ
e2etests 48.80% <100.00%> (?)
inttests 44.79% <66.66%> (+2.83%) ⬆️
unittests 19.84% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/daemons/executor/executor.go 57.81% <ø> (ø)
pkg/etcd/etcd.go 44.88% <100.00%> (+9.20%) ⬆️

... and 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@osodracnai osodracnai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please be sure to squash before merging to that we don't get that "merge branch master" commit included in the history.

In general it is a good idea to rebase your branch on top of master, instead of merging master into your branch.

@vitorsavian vitorsavian merged commit d349c9d into k3s-io:master Sep 26, 2023
15 checks passed
@vitorsavian vitorsavian deleted the cluster-reset-from-non-boostrap-nodes branch October 18, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants