-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cluster reset from non bootstrap nodes on snapshot restore e2e test #8292
Added cluster reset from non bootstrap nodes on snapshot restore e2e test #8292
Conversation
…test Signed-off-by: Vitor Savian <vitor.savian@suse.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8292 +/- ##
==========================================
+ Coverage 44.66% 51.58% +6.91%
==========================================
Files 143 143
Lines 14746 15229 +483
==========================================
+ Hits 6587 7856 +1269
+ Misses 7119 6159 -960
- Partials 1040 1214 +174
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please be sure to squash before merging to that we don't get that "merge branch master" commit included in the history.
In general it is a good idea to rebase your branch on top of master, instead of merging master into your branch.
Proposed Changes
Resets all cluster members in the test
Types of Changes
Test
Verification
go test -timeout=15m ./tests/e2e/snapshotrestore/... -run E2E
Testing
Linked Issues
User-Facing Change
Further Comments