Add context to flannel errors #8284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
requested changes
Sep 5, 2023
| @@ -49,7 +49,7 @@ var ( | |||
| func flannel(ctx context.Context, flannelIface *net.Interface, flannelConf, kubeConfigFile string, flannelIPv6Masq bool, multiClusterCIDR bool, netMode int) error { | |||
| extIface, err := LookupExtInterface(flannelIface, netMode) | |||
| if err != nil { | |||
| return err | |||
| return errors.Wrap(err, "failed to find the interface") | |||
There was a problem hiding this comment.
Looks like you need to import errors
There was a problem hiding this comment.
yep, now it should work
Signed-off-by: Manuel Buil <mbuil@suse.com>
manuelbuil
force-pushed
the
improveFlannelLogging
branch
from
a29aa30
to
66cb106
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #8284 +/- ##
==========================================
+ Coverage 47.61% 51.77% +4.16%
==========================================
Files 143 143
Lines 14732 14732
==========================================
+ Hits 7014 7627 +613
+ Misses 6623 5902 -721
- Partials 1095 1203 +108
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Sep 7, 2023
brandond
approved these changes
Sep 7, 2023
This was referenced Sep 25, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add extra context to the flannel errors to simplify debugging exercises
Types of Changes
Bugfix
Verification
Try to create an error and see the new extra information in the logs
Testing
Linked Issues
#8278
User-Facing Change
Further Comments