Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the secp256r1 curve #385

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Define the secp256r1 curve #385

merged 1 commit into from
Oct 8, 2021

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 1, 2020

This should fix #367

Would be super to try this out @m-zielinski or @obulkin. My OpenSSL version was not capable of reproducing the issue.
OpenSSL::PKey::EC.new('secp256r1') threw a OpenSSL::PKey::ECError (invalid curve name)

@obulkin
Copy link

obulkin commented Dec 28, 2020

Thanks, @anakinj. Been rather busy lately, but I'll try to validate this after the holidays.

In our case, the problematic key was pre-generated using openssl ecparam -name prime256v1. You could try to reproduce the issue this way instead, although it may still come down to have the right OpenSSL version.

@anakinj
Copy link
Member Author

anakinj commented Oct 8, 2021

Im gonna merge this. The change is just adding support for that old name.

@anakinj anakinj merged commit a79bb04 into jwt:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants