Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with master for TS changes #193

Merged
merged 88 commits into from
Feb 22, 2019
Merged

Sync with master for TS changes #193

merged 88 commits into from
Feb 22, 2019

Commits on Aug 16, 2018

  1. Configuration menu
    Copy the full SHA
    f66cecc View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Do not show undefined

    Korilakkuma committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    bce42e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. package: rm npm-run-all as it contains "event-stream" (and maybe othe…

    …r dormant exploits?). see "flatmap-stream"
    tchakabam committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    9a7b289 View commit details
    Browse the repository at this point in the history
  2. rewrite package-lock: removed event-stream and all deps got not fixed…

    … versions instead of a hat
    tchakabam committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    9735581 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Configuration menu
    Copy the full SHA
    278bf7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c9e732 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Merge pull request video-dev#2015 from video-dev/security/remove-npm-…

    …run-all
    
    Remove npm-run-all dev-dependency (see event-stream "flatmap-stream" exploit)
    tchakabam committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    0386ecb View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Configuration menu
    Copy the full SHA
    4491211 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a46bf86 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. NIT: fix typos in readme

    1.  Fix spelling of interdependent and environment
    2. Correct the agreement in the phrase: 'imported/required by each other.'
    acinader committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    c67e380 View commit details
    Browse the repository at this point in the history
  2. Merge pull request video-dev#2031 from acinader/patch-1

    NIT: fix typos in readme
    michaelcunningham19 committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    7debce3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    674b7bf View commit details
    Browse the repository at this point in the history
  4. Fix 0.11.1 Regressions (video-dev#2028)

    * Create sourceBuffers if the max of 2 tracks has been reached, regardless of buffer codec events received
    
    * Replace Object.values with [].slice.call
    johnBartos committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    e8d95a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Remux according to initial PTS so that streams start at 0 (video-dev#…

    …2030)
    
    * Buffer streams starting at 0 initPTS
    
    * Use PTS to determine if segments are contiguous
    
    * Remove code setting startPosition to buffer start
    
    * Remove seek to buffered start logic
    johnBartos committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    472614c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Simplify EOS check by using frag states, move logic into shared super…

    …class (video-dev#2040)
    
    * Simplify EOS check by using frag states, move logic into shared superclass
    
    * Move shared seek logic into base, clear fragCurrent on seek out of buffered range
    johnBartos committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    45436cd View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. Configuration menu
    Copy the full SHA
    23a07d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2018

  1. deploy demo/docs to netlify, not gh-pages

    Tom Jenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    7100b7f View commit details
    Browse the repository at this point in the history
  2. Merge pull request video-dev#2045 from video-dev/deploy-netlify

    deploy demo/docs to netlify, not gh-pages
    tjenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    24d4b50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2095e8c View commit details
    Browse the repository at this point in the history
  4. format commit as code

    because it is slightly more readable
    Tom Jenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    9053744 View commit details
    Browse the repository at this point in the history
  5. remove accidental "/" in readme

    Tom Jenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    315c8b2 View commit details
    Browse the repository at this point in the history
  6. update note to access specific version api docs

    Tom Jenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    9441fb0 View commit details
    Browse the repository at this point in the history
  7. include tag in idShort

    Tom Jenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    a3a534e View commit details
    Browse the repository at this point in the history
  8. Merge pull request video-dev#2048 from video-dev/format-commit-as-code

    format commit as code
    tjenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    3135618 View commit details
    Browse the repository at this point in the history
  9. Merge pull request video-dev#2047 from video-dev/update-demo-links-is…

    …sue-template-1
    
    update demo links in issue template
    tjenkinson committed Dec 15, 2018
    Configuration menu
    Copy the full SHA
    24fc00c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2018

  1. escape `

    tjenkinson committed Dec 16, 2018
    Configuration menu
    Copy the full SHA
    0bd2347 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c415d5a View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Merge pull request video-dev#1829 from mbeijen/isTypeSupported-audio-…

    …codecs
    
    isCodecSupportedInMp4 test audio codecs as audio
    michaelcunningham19 committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    41915f3 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. Check if PTS has wrapped after applying PTS time offset (video-dev#2056)

    * Check if PTS has wrapped after applying PTS time offset
    
    * Fix bug accessing buffered track array
    johnBartos committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    cabcfc9 View commit details
    Browse the repository at this point in the history
  2. Intialize vttCCs map with cc 0 (video-dev#2058)

    * Intiialize vttCCs map with cc 0
    johnBartos committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    a1df93a View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2018

  1. use the version from package.json when deploying

    and include this in the deployments readme
    Tom Jenkinson committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    ee97e11 View commit details
    Browse the repository at this point in the history
  2. Merge pull request video-dev#2060 from video-dev/use-package-json-ver…

    …sion-for-deploys
    
    use the version from package.json when deploying
    tjenkinson committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    259c6c0 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. Configuration menu
    Copy the full SHA
    1adc39e View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Changes clone function used in webpack config to be the webpack recom…

    …mended merging library.
    itsjamie committed Jan 11, 2019
    Configuration menu
    Copy the full SHA
    253c861 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2019

  1. Merge pull request video-dev#2075 from itsjamie/update-webpack-merge

    Update light build targets to include Typescript extensions
    michaelcunningham19 committed Jan 12, 2019
    Configuration menu
    Copy the full SHA
    7021254 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Merge pull request video-dev#2069 from jonnyboris/master

    Docs: abrBandWidthFactor and abrBandWidthUpFactor
    michaelcunningham19 committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    88a084b View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. Configuration menu
    Copy the full SHA
    1896cf7 View commit details
    Browse the repository at this point in the history
  2. docs: add bandwidthEstimate

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    16685b3 View commit details
    Browse the repository at this point in the history
  3. test: add autotest

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    c4e802c View commit details
    Browse the repository at this point in the history
  4. Convert buffer-controller.js to TypeScript

    Thank you to Tom Jenkinson for acting as a reviewer for this work, including writing some suggestions via the GitHub PR github.com/video-dev/pull/2073. The commit history has been squashed as it was a fairly lengthly process to get everything working to support the conversion to TypeScript.
    
    Early in the history of this commit, we converted properties to be initialized to `null`. This was incorrect, as it changes the behaviour of code that uses `Object.keys` calls to check if an object has any keys on it. Before, they would be empty, but if the properties are set to null, this check is no longer valid and it changes the behaviour. This is something to look out for in the future of other conversions, as the values themselves are often times reset to the `null`, but begin as undefined.
    
    Added a common `types` folder for interfaces where the ownership of the type wasn't clear for the individual file. The default no-op logger which is the inferred usage did not have any arguments in it's method signature. By adding an argument, TypeScript is able to infer the correct interface. As well the Karma and Webpack configuration had to be updated to enable building TypeScript, and getting testing coverage information from Istanbul.
    
    Define lib "es2015" and "dom" to add HTMLMediaElement, SourceBuffer and Number.isFinite definitions to the TypeScript binary when it is doing type-checking.
    
    When attempting to lint the older version of `typescript-eslint-parser` would emit `no-undef` errors for TypeScript interfaces. Updating the package fixes this issue.
    
    Tom pointed out that we should not use global module declarations to extend default HTML types since users will eventually be importing *.d.ts files from the hls.js project and this would also extend their types. Due to this feedback switched to defining a module local type `ExtendedSourceBuffer`. Which instead extends with the `ended` prop.
    
    Event Handlers were set to be part of the private scope. While this has no effect now, it will be important to ensure other modules do not directly invoke the event handlers. Other methods that were prefixed with a `_` were also set into the private scope.
    
    Where possible, code was switched to early-exit to lower the cognitive load in conditional statements, an example of this was the doAppend method. Another cleanup statement was switching handling of error codes and the comments to be closer to the conditional to which they applied.
    
    Switched to using the Record<Key, Value> type to help support access via the index signature [key: T] syntax in the future.
    
    An issue that was fixed in this commit was that The controller previous exposed the local `pendingTracks` property through the event and did not set the buffer on `this.tracks` instead opting to set it on the individual track, which bubbled up to the pendingTracks object, whose reference was lost in the buffer-controller module. This commit changes this behaviour so that the controller publishes `tracks` from the public variable on the controller rather than the pendingTracks which are passed into createSourceBuffers. This also means that this fixes the `.buffer.buffered` being undefined on the demo page. Added unit tests to cover the new behaviour of throwing an error if createSourceBuffer is called without an attached media element.
    itsjamie committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    ea3e1f0 View commit details
    Browse the repository at this point in the history
  5. test: review changes

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    20ac9cb View commit details
    Browse the repository at this point in the history
  6. docs: review fix

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    982f309 View commit details
    Browse the repository at this point in the history
  7. prod: add review fix

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    3eaa870 View commit details
    Browse the repository at this point in the history
  8. docs: update

    Co-Authored-By: Beraliv <beraliv.spb@gmail.com>
    johnBartos and Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    a0465f6 View commit details
    Browse the repository at this point in the history
  9. docs: update 2

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    86ec335 View commit details
    Browse the repository at this point in the history
  10. docs: fix link

    Beraliv committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    938eaba View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. test: equal => strictEqual

    Beraliv committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    77be93d View commit details
    Browse the repository at this point in the history
  2. test: add mocked _bwEstimator

    Beraliv committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    4af7ed9 View commit details
    Browse the repository at this point in the history
  3. test: change description

    Beraliv committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    946ed07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fee36fd View commit details
    Browse the repository at this point in the history
  5. Merge pull request video-dev#2073 from itsjamie/buffer-controller-ts

    Buffer Controller TypeScript
    michaelcunningham19 committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    e2e480f View commit details
    Browse the repository at this point in the history
  6. Merge pull request video-dev#2086 from Beraliv/master

    Make bandwidth estimate public API
    michaelcunningham19 committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    dc6c404 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3fd4e2a View commit details
    Browse the repository at this point in the history
  8. Increase adts.js test coverage to 100% (video-dev#2053)

    * Increase adts.js test coverage to 100%
    springuper authored and johnBartos committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    d8be3dc View commit details
    Browse the repository at this point in the history
  9. Convert eme-controller to TypeScript.

    Added TypeScript types to the code.
    
    Handled media detached and removing the encrypted event listener.
    itsjamie committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    4e2ae38 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Listen to media detached

    Clears the encrypted event listener from the HTMLMediaElement in controller, and releases the stored reference.
    itsjamie committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    63db40f View commit details
    Browse the repository at this point in the history
  2. Choose bitrate in Bps (video-dev#2091)

    Simplify bandwidth calculation by making; change docs to correctly reference bandwidth in bits/s
    Beraliv authored and johnBartos committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    3e43bf9 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Merge pull request video-dev#2076 from itsjamie/eme-controller-ts

    EME Controller TypeScript
    michaelcunningham19 committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    361b563 View commit details
    Browse the repository at this point in the history
  2. Upgrade tests to Chai BDD & optimize runner (video-dev#2037)

    * Convert tests to Chai BDD
    
    * Invoke mocha with exit so that travis doesnt hang on func test completion
    johnBartos committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    86b4e15 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Fix video-dev#2061

    itsjamie committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    260a8a0 View commit details
    Browse the repository at this point in the history
  2. configure netlify for PR's

    this follows the same process that runs for canary releases
    Tom Jenkinson committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    d93d453 View commit details
    Browse the repository at this point in the history
  3. check if repo is shallow before fetching

    because on netlify it clones the whole thing
    Tom Jenkinson committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    e5a3a78 View commit details
    Browse the repository at this point in the history
  4. handle 'netlifyPr' in set-package-version

    Tom Jenkinson committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    35c4553 View commit details
    Browse the repository at this point in the history
  5. tabs => spaces

    Tom Jenkinson committed Jan 26, 2019
    Configuration menu
    Copy the full SHA
    a8f99c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2019

  1. add commit to version when PR

    Tom Jenkinson committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    f69bf3e View commit details
    Browse the repository at this point in the history
  2. always trim command output

    Tom Jenkinson committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    e2e71c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Configuration menu
    Copy the full SHA
    e7f9c9e View commit details
    Browse the repository at this point in the history
  2. Merge pull request video-dev#2101 from video-dev/netlify

    configure netlify for PR's
    tjenkinson committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    dcb3db6 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Configuration menu
    Copy the full SHA
    64f13c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af437da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40e81b8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a80ff2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b37a351 View commit details
    Browse the repository at this point in the history
  6. Apply suggestions from code review

    Co-Authored-By: itsjamie <1956521+itsjamie@users.noreply.github.com>
    tjenkinson and itsjamie committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    a742c30 View commit details
    Browse the repository at this point in the history
  7. Review changes.

    parseByteRange -> setByteRange
    - removed it returning the parsed value since its usage was like a setter.
    itsjamie committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    2e2cb12 View commit details
    Browse the repository at this point in the history
  8. Review comments pt.2

    itsjamie committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    c8b0048 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    150d1e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Configuration menu
    Copy the full SHA
    9329b55 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0c28c5 View commit details
    Browse the repository at this point in the history
  3. fix console null reference in logger (in webworkers) (video-dev#2095)

    Fix null reference in logger when console is not available
    mad-gooze authored and johnBartos committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    5b6d7fe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ec1700d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3902e1f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. Configuration menu
    Copy the full SHA
    a31f1be View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Merge pull request video-dev#2107 from itsjamie/fragment-typescript

    Apply TypeScript to Fragment & LevelKey
    michaelcunningham19 committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    2bd34b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Update webpack to use babel loader with support for TS. (video-dev#2119)

    * Upgrade to webpack 4, babel 7
    
    * Use straight git link for webworkify dep
    
    * Use simpler git url
    
    * Re-add globalObject workaround
    
    * Bump karma dep versions
    
    * Dont preprocess non-test files
    
    * Use @babel/register over ts-node
    
    * Update demo `const` usage.
    
    * Use webpack debug config in Karma configuration rather than duplication.
    itsjamie authored and johnBartos committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    0bbb9b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Sync upstream TS changes

    John Bartos committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    49daa3f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Delete duplicate declaration

    John Bartos committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    ee67a14 View commit details
    Browse the repository at this point in the history
  2. Resolve merge conflicts

    John Bartos committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    911c172 View commit details
    Browse the repository at this point in the history