Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Setuptools for Python 3.12 #244

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Replace Setuptools for Python 3.12 #244

merged 3 commits into from
Apr 25, 2024

Conversation

branchvincent
Copy link
Contributor

@branchvincent branchvincent commented Apr 25, 2024 •
edited
Loading

Fixes #240

Python 3.12 removed distutils and bundled setuptools (aka pkg_resources): https://docs.python.org/3.12/whatsnew/3.12.html#removed

Also bumps to python 3.8+ (since 3.7 is unsupported and would require a backport of importlib.metadata)

@justinmayer justinmayer changed the title replace setuptools for python 3.12 Replace Setuptools for Python 3.12 Apr 25, 2024
justinmayer
justinmayer approved these changes Apr 25, 2024
View reviewed changes
Copy link
Owner

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for resolving the compatibility issue with Python 3.12. Nice work. Much appreciated! 🏅

@justinmayer justinmayer merged commit 910dff3 into justinmayer:main Apr 25, 2024
2 checks passed
@branchvincent branchvincent deleted the setuptools branch April 25, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from pkg_resources to importlib
2 participants
@branchvincent @justinmayer