Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Enable auto scrolling for outputs by default #288

Merged
merged 9 commits into from
Jan 3, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 15, 2021

@jtpio jtpio added the enhancement New feature or request label Nov 15, 2021
@jtpio jtpio added this to the 0.3.x milestone Nov 15, 2021
@github-actions
Copy link
Contributor

Binder 👈 Launch RetroLab on Binder

@jtpio jtpio marked this pull request as draft November 15, 2021 21:33
@jtpio
Copy link
Member Author

jtpio commented Nov 15, 2021

Converting to draft for now.

We should check the logic in the classic notebook to handle the auto scrolling.

With the naive logic as it is now in this PR this would enable it even for small outputs:

image

@yuvipanda
Copy link
Contributor

Trying to match classic makes sense here. I think we should eventually upstream this into lab, but this is a great place to try this out. Thanks a lot for looking into this, @jtpio

@jtpio
Copy link
Member Author

jtpio commented Nov 16, 2021

@jtpio
Copy link
Member Author

jtpio commented Dec 29, 2021

A follow-up to this would be to update to JupyterLab 3.2.5 packages to grab jupyterlab/jupyterlab#11478

@jtpio
Copy link
Member Author

jtpio commented Dec 29, 2021

Opened jupyterlab/jupyterlab#11760 to track that upstream.

@jtpio jtpio marked this pull request as ready for review December 29, 2021 17:30
@jtpio
Copy link
Member Author

jtpio commented Dec 29, 2021

cc @yuvipanda if you want to give it a try on Binder: https://mybinder.org/v2/gh/jtpio/retrolab/scroll-outputs?urlpath=retro/tree

I'll do a bit more testing but if it works fine we can merge and release.

Thinking we might also want to make it possible to disable that behavior via the settings system (opt-out).

@jtpio jtpio changed the title Enable auto scrolling for outputs Enable auto scrolling for outputs by default Dec 31, 2021
@jtpio
Copy link
Member Author

jtpio commented Dec 31, 2021

Thinking we might also want to make it possible to disable that behavior via the settings system (opt-out).

Implemented in 84df24d

@jtpio
Copy link
Member Author

jtpio commented Jan 3, 2022

Did some more testing on Binder and it seems to be working fine.

Will make a new release with this change after merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automatically scroll output area with large text outputs
2 participants