Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow room opening #264

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix slow room opening #264

merged 2 commits into from
Mar 27, 2024

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Mar 27, 2024 •
edited
Loading

Fixes #263.

cc @trungleduc

@davidbrochart davidbrochart marked this pull request as draft March 27, 2024 17:07
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/fix-room-lock

@davidbrochart davidbrochart added the bug Something isn't working label Mar 27, 2024
@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Mar 27, 2024 •
edited
Loading

I just added a test, that currently fails.

@davidbrochart
Copy link
Collaborator Author

The test now passes (it fails at teardown due to aiosqlite, see this issue and this PR).

@davidbrochart davidbrochart marked this pull request as ready for review March 27, 2024 17:19
@Zsailer
Copy link
Member

Zsailer commented Mar 27, 2024

Oh nice! (I think) I observed this issue too, but wasn't able to reproduce it reliably, so I wasn't able to create a bug report.

@trungleduc
Copy link
Member

Thanks @davidbrochart for the quick reaction!

@davidbrochart davidbrochart merged commit 8f55ea5 into jupyterlab:main Mar 27, 2024
15 of 21 checks passed
@davidbrochart davidbrochart deleted the fix-room-lock branch March 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zsailer Zsailer Zsailer approved these changes

@trungleduc trungleduc trungleduc approved these changes

@jzhang20133 jzhang20133 jzhang20133 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long loading time in 2.0.5
4 participants
@davidbrochart @Zsailer @trungleduc @jzhang20133