Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python<3.10 compatibility #899

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

michaelchia
Copy link
Contributor

Replacing PEP 604 syntax str | None with Optional[str]. PEP 604 was only introduced in python3.10.

@dlqqq dlqqq added the bug Something isn't working label Jul 16, 2024
@dlqqq dlqqq changed the title Support python>=3.8 compatibility Fix python<3.10 compatibility Jul 16, 2024
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@dlqqq dlqqq enabled auto-merge (squash) July 16, 2024 17:18
@dlqqq dlqqq merged commit 83c0cf8 into jupyterlab:main Jul 16, 2024
8 checks passed
@michaelchia
Copy link
Contributor Author

hi, is it possible to release this fix early next week? I need the langchain>0.2 change but can't upgrade until this is resolved.

@dlqqq
Copy link
Collaborator

dlqqq commented Jul 22, 2024

@michaelchia NP! I'll cut a patch release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants