Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new models to Bedrock provider #499

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

JasonWeill
Copy link
Collaborator

@JasonWeill JasonWeill commented Dec 2, 2023

Fixes #495 to add new models for Anthropic Claude v2.1, Cohere command-light-text-v14, Meta Llama2-13b-chat-v1, and Meta Llama2-70b-chat-v1.

Models work with the us-east-1 Bedrock endpoint.

@JasonWeill JasonWeill added the enhancement New feature or request label Dec 2, 2023
@JasonWeill JasonWeill marked this pull request as draft December 2, 2023 00:15
@3coins
Copy link
Collaborator

3coins commented Dec 4, 2023

@JasonWeill
Can you investigate this further, and check if an update on the upstream LangChain project is required; try upgrading to latest LangChain version that might fix this. Thanks.

Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasonWeill
Thanks for making these changes. I did a round of testing, LangChain upgrade works, along with the new models. See my comment about adding Llama models to BedrockChat. If you have already tried this with subpar results in chat, go ahead with merging this.

@JasonWeill JasonWeill merged commit b71e0ec into jupyterlab:main Dec 8, 2023
6 checks passed
@JasonWeill
Copy link
Collaborator Author

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Dec 11, 2023
JasonWeill added a commit that referenced this pull request Dec 11, 2023
Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* Adds new parameters

* Updates LangChain to newest version

* Moves chat models to BedrockChat provider

* Moves llama2 chat models back to BedrockProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bedrock models announced in November 2023
2 participants