Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yarn install in CI #174

Merged
merged 6 commits into from
May 17, 2023
Merged

Fix yarn install in CI #174

merged 6 commits into from
May 17, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented May 17, 2023 •
edited
Loading

Fixes check-release workflow that is currently failing on latest main: https://github.com/jupyterlab/jupyter-ai/actions/runs/5003822667/jobs/8965550977

@dlqqq dlqqq added the bug Something isn't working label May 17, 2023
@dlqqq
Copy link
Member Author

dlqqq commented May 17, 2023

The root cause was the JupyterLab 4.0.0 release. Previously we were installing jupyterlab (and by extension, jlpm) via this command in the before-build-npm Jupyter Releaser step:

before-build-npm = [
    "python -m pip install jupyterlab",
    "jlpm",
    "jlpm build:prod"
]

Setting a version specifier like ~=3.6 fixes the issue. JL4 support is being tracked in #173.

@dlqqq dlqqq marked this pull request as ready for review May 17, 2023 15:07
JasonWeill
JasonWeill approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, build still passes locally

@dlqqq dlqqq merged commit e82c672 into jupyterlab:main May 17, 2023
@dlqqq dlqqq deleted the fix-ci branch May 17, 2023 15:24
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@dlqqq
Fix yarn install in CI (jupyterlab#174)
df6925e 
* add runner debug step in check release workflow

* print jlpm version in debug

* update yarn.lock

* run debug step after check-release

* always run debug step

* use exclusively JL3 in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonWeill JasonWeill JasonWeill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlqqq @JasonWeill