Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak font styles for code blocks in chat #148

Merged
merged 1 commit into from
May 6, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented May 5, 2023

Description

Binds the line-height, font-family, and font-size CSS properties to the CSS variables used in JupyterLab.

Unfortunately I'm not having much luck changing the color scheme of the code block; the dependency is outdated and most of the styles are broken out-of-the-box. We will likely have to migrate to the JupyterLab code renderer soon.

Demo

Screen Shot 2023-05-05 at 10 53 45 AM

@dlqqq dlqqq added the enhancement New feature or request label May 5, 2023
@3coins
Copy link
Collaborator

3coins commented May 5, 2023

@dlqqq
Thanks for making these tweaks. Should we decrease the spacing between the “Copy To Clipboard” and the code block to specify better context? We can also explore moving it to the top of code block.

@dlqqq
Copy link
Member Author

dlqqq commented May 6, 2023

@3coins That's a great suggestion! However, there are lots of other changes that need to be made regarding how we present code blocks to the end user after JupyterCon. I think it's best to track that in our internal design for now.

@dlqqq dlqqq merged commit 76278de into jupyterlab:main May 6, 2023
@dlqqq dlqqq deleted the fix-code-font branch May 6, 2023 17:43
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants