Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update providers.py #145

Merged
merged 2 commits into from
May 5, 2023
Merged

Update providers.py #145

merged 2 commits into from
May 5, 2023

Conversation

thorhojhus
Copy link
Contributor

BaseLanguageModel has been changed to BaseModel in Langchain. This fixes the plugin for version 0.0.158 of Langchain

@welcome
Copy link

welcome bot commented May 5, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@dlqqq
Copy link
Member

dlqqq commented May 5, 2023 •
edited
Loading

@thorhojhus Thank you for your contribution! 🤗 We are currently pinning LangChain to an older version to work around this. Hence, the dependencies also need to be updated in the corresponding pyproject.toml files. This is a small change, so I can help with that and then proceed to merge. I'll also need to rebase this branch to fix CI.

thorhojhus and others added 2 commits May 5, 2023 14:49
@thorhojhus @dlqqq
Update providers.py
f6a9138 
BaseLanguageModel has been changed to BaseModel in Langchain. This fixes the plugin for version 0.0.158 of Langchain
@dlqqq
update langchain version
1eeefa5
dlqqq
dlqqq approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased with the LangChain versions pinned; will merge pending green CI. 👍

@dlqqq dlqqq added the enhancement New feature or request label May 5, 2023
@dlqqq
Copy link
Member

dlqqq commented May 5, 2023

Thank you for your contribution! 🎉

@dlqqq dlqqq merged commit e672c8f into jupyterlab:main May 5, 2023
@welcome
Copy link

welcome bot commented May 5, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@thorhojhus @dlqqq
Update providers.py (jupyterlab#145)
fedd866 
* Update providers.py 

BaseLanguageModel has been changed to BaseModel in Langchain. This fixes the plugin for version 0.0.158 of Langchain

* update langchain version

---------

Co-authored-by: David L. Qiu <david@qiu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorhojhus @dlqqq