Disable replaceSelection if nothing is selected

jupyterlab · Jun 30, 2023 · ecd0610 · ecd0610
1 parent c772ac1
commit ecd0610
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/jupyter-ai/src/components/chat.tsx b/packages/jupyter-ai/src/components/chat.tsx
@@ -145,6 +145,9 @@ function ChatBody({
     );
   }
 
+  // If there is no selection, the "replace selection" button will not be
+  // visible; treat it as disabled
+  const hasSelection = !!selection?.text;
   return (
     <>
       <ScrollContainer sx={{ flexGrow: 1 }}>
@@ -154,12 +157,12 @@ function ChatBody({
         value={input}
         onChange={setInput}
         onSend={onSend}
-        hasSelection={!!selection?.text}
+        hasSelection={hasSelection}
         includeSelection={includeSelection}
         toggleIncludeSelection={() =>
           setIncludeSelection(includeSelection => !includeSelection)
         }
-        replaceSelection={replaceSelection}
+        replaceSelection={hasSelection && replaceSelection}
         toggleReplaceSelection={() =>
           setReplaceSelection(replaceSelection => !replaceSelection)
         }