relearn on /ask if embedding model was changed

jupyterlab · Jul 5, 2023 · 1d1fd82 · 1d1fd82
1 parent dff5129
commit 1d1fd82
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py b/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py
@@ -252,16 +252,18 @@ def load_metadata(self):
             j = json.loads(f.read())
             self.metadata = IndexMetadata(**j)
 
-    def get_relevant_documents(self, question: str) -> List[Document]:
-        if self.index:
-            docs = self.index.similarity_search(question)
-            return docs
-        return []
+    def get_relevant_documents(self, query: str) -> List[Document]:
+        raise NotImplementedError()
 
     async def aget_relevant_documents(
         self, query: str
     ) -> Coroutine[Any, Any, List[Document]]:
-        return self.get_relevant_documents(query)
+        if not self.index:
+            return []
+
+        await self.delete_and_relearn()
+        docs = self.index.similarity_search(query)
+        return docs
 
     def get_embedding_provider(self):
         em_provider_cls = self.config_manager.get_em_provider()