Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename migration file to migrate_to_notebook7 #6831

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 5, 2023

Fixes #6830

So we don't have to update the link in NBClassic + Notebook 6.5.x and make new releases.

@jtpio jtpio added this to the 7.0 milestone Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Binder 👈 Launch a Binder on branch jtpio/notebook/rename-migrating-file

ashwinvis and others added 4 commits April 5, 2023 13:54
As noted in readthedocs/readthedocs.org#10224 with the current configuration the canonical URL is wrong with different sphinx builds. For instance the "latest" docs point to "stable". This leads to apps like Mastodon to generate previews to pages which don't exist since they rely on

    <link rel="canonical" href="https://jupyter-notebook.readthedocs.io/en/stable/notebook_7_features.html" />

This should fix that.
@jtpio jtpio marked this pull request as ready for review April 5, 2023 12:01
@jtpio jtpio enabled auto-merge (squash) April 5, 2023 12:03
@jtpio jtpio merged commit 1512c82 into jupyter:main Apr 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in jupyter
2 participants