Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added white space to bottom of edit files #6804

Merged
merged 2 commits into from
Mar 30, 2023
Merged

added white space to bottom of edit files #6804

merged 2 commits into from
Mar 30, 2023

Conversation

jesuscastillx
Copy link
Contributor

@jesuscastillx jesuscastillx commented Mar 29, 2023 •
edited

Fixes a part of #6785 - Text editor should display a partial view.
New view:
Screen Shot 2023-03-29 at 11 26 00 AM

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch j-publius/jupyternotebookfork/add-bottom-spacer

jesuscastillx
jesuscastillx commented Mar 29, 2023
View reviewed changes
notebook/templates/edit.html Outdated
@@ -8,7 +8,7 @@
<link rel="icon" type="image/x-icon" href="{{ base_url | escape }}static/favicons/favicon-file.ico" class="favicon">
{% endblock %}
</head>
<body>
<body data-edit="edit">
Copy link
Contributor Author

@jesuscastillx jesuscastillx Mar 29, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning for doing it this way is that the notebook template has an attribute just like this. It is only ever referenced in this and this CSS file for the purposes of styling.

This allows me to target exclusively edit pages to add the spacer at the bottom.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case maybe it should be for consistency:

Suggested change
<body data-edit="edit">
<body data-notebook="edit">

@jesuscastillx jesuscastillx marked this pull request as draft March 29, 2023 01:24
@jesuscastillx jesuscastillx reopened this Mar 29, 2023
@jesuscastillx jesuscastillx marked this pull request as ready for review March 29, 2023 01:29
@jesuscastillx jesuscastillx mentioned this pull request Mar 29, 2023
Closed
@jtpio jtpio added the bug label Mar 29, 2023
@jtpio jtpio added this to the 7.0 milestone Mar 29, 2023
@jtpio
Copy link
Member

jtpio commented Mar 29, 2023

Thanks @j-publius for working on this 👍

Would you mind adding a screenshot to the top comment to get an idea of what it looks like?

@jesuscastillx
Copy link
Contributor Author

Thanks @j-publius for working on this 👍

Would you mind adding a screenshot to the top comment to get an idea of what it looks like?

Added + updated attribute value for consistency

@jtpio jtpio mentioned this pull request Mar 30, 2023
Open
5 tasks
jtpio
jtpio approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 9355169 into jupyter:main Mar 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@jesuscastillx jesuscastillx

Labels
bug
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesuscastillx @jtpio