Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4.0.0a35 #6757

Merged
merged 14 commits into from
Mar 7, 2023
Merged

Conversation

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Binder 👈 Launch a Binder on branch jtpio/notebook/update-jupyterlab-alpha

@jtpio jtpio added this to the 7.0 milestone Mar 3, 2023
@jtpio jtpio changed the title Update jupyterlab alpha Update to JupyterLab 4.0.0a35 Mar 3, 2023
@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2023

bot please update playwright snapshots

@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2023

Ah looks like there is a glitch with the "Interface" dropdown menu (showing ... instead on notebook load):

image

@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2023

bot please update playwright snapshots

@fcollonval
Copy link
Collaborator

@jtpio, I forgot about it but the new hamburger feature is under a boolean flag options.overflowMenuOptions.overflowMenuVisible :

https://github.com/jupyterlab/lumino/blob/e3c221345ca69dd2517b479d66911077f97ae7c4/packages/widgets/src/menubar.ts#L1114

@jtpio
Copy link
Member Author

jtpio commented Mar 3, 2023

@fcollonval yeah this was added in 6e0cd07.

But according to the bot snapshot update it does not seem to be taken into account? (now showing up as empty because of title set to ''?)

image

@jtpio
Copy link
Member Author

jtpio commented Mar 7, 2023

bot please update playwright snapshots

@jtpio
Copy link
Member Author

jtpio commented Mar 7, 2023

bot please update playwright snapshots

@jtpio jtpio closed this Mar 7, 2023
@jtpio jtpio reopened this Mar 7, 2023
@jtpio
Copy link
Member Author

jtpio commented Mar 7, 2023

Looks like jupyterlab/lumino#550 did fix the issue with menu bar.

@jtpio jtpio marked this pull request as ready for review March 7, 2023 13:38
@jtpio
Copy link
Member Author

jtpio commented Mar 7, 2023

And also looking good on Binder now:

image

@jtpio jtpio merged commit 4a0387f into jupyter:main Mar 7, 2023
@jtpio jtpio deleted the update-jupyterlab-alpha branch March 7, 2023 13:42
@jtpio jtpio mentioned this pull request Mar 7, 2023
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants