Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TypeScript 5 #6735

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Update to TypeScript 5 #6735

merged 1 commit into from
Feb 20, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 15, 2023

@jtpio jtpio added this to the 7.0 milestone Feb 15, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/ts-5

@jtpio jtpio marked this pull request as ready for review February 20, 2023 14:52
@jtpio
Copy link
Member Author

jtpio commented Feb 20, 2023

CI passes although skipLibCheck is still enabled for now (probably due to legacy config):

notebook/tsconfigbase.json

Line 17 in e7b5c37

"skipLibCheck": true,

We can track removing skipLibCheck in a separate PR, maybe while updating to next JupyterLab 4 pre-release: #6734

@jtpio jtpio merged commit 3aa73cb into jupyter:main Feb 20, 2023
@jtpio jtpio deleted the ts-5 branch February 20, 2023 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jtpio jtpio

Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtpio