Adds translator to the NotebookShell #6725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
force-pushed
the
localize_notebook_shell
branch
from
c891754
to
87fb953
Compare
jtpio
reviewed
Feb 9, 2023
| import { ITranslator } from '@jupyterlab/translation'; | ||
| import { INotebookShell } from '@jupyter-notebook/application'; | ||
|
|
||
| const translator: JupyterFrontEndPlugin<void> = { |
There was a problem hiding this comment.
Wondering if we need to create a new package for this plugin.
Or maybe we put the plugin in application-extension directly to keep things simpler: https://github.com/jupyter/notebook/blob/main/packages/application-extension/src/index.ts
jtpio
reviewed
Feb 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a translator to the NotebookShell, and translates the title of the side panels button.
Fixes #6722
Related discussion at #6719 (comment)