Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce desktop file #6705

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Reintroduce desktop file #6705

merged 2 commits into from
Jan 27, 2023

Conversation

frenzymadness
Copy link
Contributor

The desktop file was inadvertently removed in: 5b6ed99

Fixes: #6704

I did check that the files are present in the sdist and wheel archives:

$ tar -tf dist/notebook-7.0.0a11.tar.gz| grep -E "notebook\.(svg|desktop)"
notebook-7.0.0a11/jupyter-notebook.desktop
notebook-7.0.0a11/notebook.svg
notebook-7.0.0a11/node_modules/@jupyterlab/ui-components/style/icons/filetype/notebook.svg

$ zip -sf dist/notebook-7.0.0a11-py3-none-any.whl | grep -E "notebook\.(svg|desktop)"
  notebook-7.0.0a11.data/data/share/applications/jupyter-notebook.desktop
  notebook-7.0.0a11.data/data/share/icons/hicolor/scalable/apps/notebook.svg

The desktop file was inadvertently removed in: jupyter@5b6ed99

Fixes: jupyter#6704
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch frenzymadness/notebook/desktop_file

@jtpio jtpio added this to the 7.0 milestone Jan 27, 2023
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 229247f into jupyter:main Jan 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing jupyter-notebook.desktop file in version 7
2 participants