Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help-extension split into multiple plugins #6700

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Help-extension split into multiple plugins #6700

merged 3 commits into from
Jan 18, 2023

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Jan 18, 2023

Fix #6406

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch RRosio/notebook/split-help-extension

@jtpio jtpio added this to the 7.0 milestone Jan 18, 2023
@jtpio
Copy link
Member

jtpio commented Jan 18, 2023

Thanks @RRosio for working on this!

@RRosio RRosio marked this pull request as ready for review January 18, 2023 15:09
@RRosio @jtpio
Update packages/help-extension/src/index.tsx
ca61bdc 
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@RRosio
Copy link
Collaborator Author

RRosio commented Jan 18, 2023

Thank you @jtpio! I made this change locally however when re-installing notebook the Help menu option no longer contains the About Jupyter Notebook and Keyboard Shortcuts sections. I was thinking maybe I need to update the schema as well?

@jtpio
Copy link
Member

jtpio commented Jan 18, 2023

Right, probably this file would need to be renamed then: https://github.com/jupyter/notebook/blob/main/packages/help-extension/schema/plugin.json

@RRosio
Copy link
Collaborator Author

RRosio commented Jan 18, 2023

Thank you! I just submitted that change.

@jtpio
Copy link
Member

jtpio commented Jan 18, 2023

Thanks!

I just tried on Binder with the latest changes and it looks good:

image

jtpio
jtpio approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 6d4eeed into jupyter:main Jan 18, 2023
@jtpio jtpio mentioned this pull request Jan 19, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@RRosio RRosio

Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Split the help extension into multiple plugins
2 participants
@RRosio @jtpio