Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathlib instead of os.path.join in tests/conftest.py #6624

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Use pathlib instead of os.path.join in tests/conftest.py #6624

merged 1 commit into from
Nov 17, 2022

Conversation

kianelbo
Copy link
Contributor

Fixes #6622

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch kianelbo/notebook/conftest-pathlib

@jtpio jtpio added this to the 7.0 milestone Nov 16, 2022
jtpio
jtpio approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 707e9c4 into jupyter:main Nov 17, 2022
@kianelbo kianelbo deleted the conftest-pathlib branch November 17, 2022 14:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Modernize os operations in conftest.py
2 participants
@kianelbo @jtpio