Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the nbclassic explicit uninstall on Binder #6548

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 29, 2022

Fixes #6547

The Binder build should hopefully pick up the nbclassic>=0.4.4: jupyter/nbclassic#141 (comment)

@jtpio jtpio added this to the 7.0 milestone Sep 29, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/nbclassic-binder

@jtpio
Copy link
Member Author

jtpio commented Sep 30, 2022

This is still an issue, probably because the pre-installed nbclassic on Binder is still 0.4.3:

image

@jtpio
Copy link
Member Author

jtpio commented Oct 14, 2022

This will likely be fixed by jupyterhub/repo2docker#1193

@jtpio
Copy link
Member Author

jtpio commented Oct 15, 2022

This seems to be fixed now that jupyterhub/repo2docker#1193 is live on mybinder.org:

image

@jtpio jtpio marked this pull request as ready for review October 15, 2022 08:18
@jtpio jtpio merged commit b14def0 into jupyter:main Oct 15, 2022
@jtpio jtpio deleted the nbclassic-binder branch October 15, 2022 08:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nbclassic explicit uninstall on Binder
1 participant