Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall nbclassic on Binder so Notebook v7 can load #6505

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 4, 2022

As noted in #6496 (comment), Binder does not start v7 anymore:

image

This is currently happening on the main branch. Opening this PR to troubleshoot the issue.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Binder 👈 Launch a Binder on branch jtpio/notebook/fix-binder

@jtpio jtpio added this to the 7.0 milestone Aug 4, 2022
@jtpio
Copy link
Member Author

jtpio commented Aug 4, 2022

Arf Binder seems to be getting some rate limiting errors at the moment, oh well let's wait then...

image

@jtpio
Copy link
Member Author

jtpio commented Aug 4, 2022

A guess might be it's related to the recent nbclassic releases which also use the same /tree endpoint.

@jtpio
Copy link
Member Author

jtpio commented Aug 4, 2022

A guess might be it's related to the recent nbclassic releases which also use the same /tree endpoint.

Yes, explicitly uninstalling nbclassic (which might be coming from the base Binder / repo2docker setup) in the postBuild does the trick:

image

@jtpio jtpio changed the title Troubleshoot Binder Uninstall nbclassic on Binder so Notebook v7 can load Aug 4, 2022
@jtpio jtpio marked this pull request as ready for review August 4, 2022 16:51
@jtpio
Copy link
Member Author

jtpio commented Aug 4, 2022

Merging since this fixes the Binders for previewing PRs as well.

@jtpio jtpio merged commit c6faa5c into jupyter:main Aug 4, 2022
@jtpio jtpio deleted the fix-binder branch August 4, 2022 17:05
@jtpio jtpio mentioned this pull request Aug 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant