Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the tab renderer to allow adding closable tab #6477

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Jul 19, 2022

This PR add a close icon on new closable tab in tree-extension.

Fix #6476

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/notebook/fix/closable_tab

@jtpio jtpio added this to the 7.0 milestone Jul 19, 2022
@jtpio
Copy link
Member

jtpio commented Jul 19, 2022

Thanks @brichet this can also be useful for #6316.

@@ -3,19 +3,19 @@

import {
JupyterFrontEnd,
JupyterFrontEndPlugin
JupyterFrontEndPlugin,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these prettier changes added automatically on commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally the local dev install should pull the right version of prettier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I couldn't commit because of prettier check, so I ran jlpm prettier and add the changes.
But the command did have change a lot of files, with the same kind of modification.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to do a clean local install in a new environment to make sure the right dependencies are pulled?

Copy link
Contributor Author

@brichet brichet Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio, I had some weird files in node-modules/.bin.
jlpm clean did the trick.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit fb5d503 into jupyter:main Jul 20, 2022
@brichet brichet deleted the fix/closable_tab branch July 20, 2022 08:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close icon is not displayed on new tab
2 participants