Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow to cells #6433

Merged
merged 1 commit into from
May 30, 2022
Merged

Add shadow to cells #6433

merged 1 commit into from
May 30, 2022

Conversation

trungleduc
Copy link
Contributor

Reference

Fixes #6432

Code changes

Update style of cell element.

User-facing changes

Add shadows around the notebook to make it look like in v6

  • Current notebook
    v7-old

  • New notebook
    v7-fix

  • v6 notebook for reference
    v6

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/notebook/add-cell-shadow

@trungleduc trungleduc marked this pull request as draft May 21, 2022 21:15
@trungleduc trungleduc marked this pull request as ready for review May 21, 2022 22:33
@jtpio jtpio added this to the 7.0 milestone May 30, 2022
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jtpio jtpio merged commit 6a2f5c7 into jupyter:main May 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing shadows around the notebook in v7
2 participants