Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize handler page_config from Server traitlets #6366

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

bollwyvl
Copy link
Contributor

This initializes page_config from, e.g. ServerApp.tornado_settings.page_config_data. These values can be subsequently overwritten by other configurables.

This corresponds to LabHandler in jupyterlab_server.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch bollwyvl/notebook/add-default-page-config

@jtpio jtpio added this to the 7.0 milestone Apr 19, 2022
@jtpio
Copy link
Member

jtpio commented Apr 19, 2022

Thanks!

Looks like this adds the following two items to the File menu (noticed by the UI tests):

image

Which is fine. We can always re-work the snapshots later via the settings system so they look more like the ones from the classic notebook:

image

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 60f1f01 into jupyter:main Apr 19, 2022
@bollwyvl
Copy link
Contributor Author

Thanks!

@bollwyvl bollwyvl deleted the add-default-page-config branch April 19, 2022 16:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants