Fix asyncio error when opening notebooks #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for jupyter#6164 `nest_asyncio` must be applied before any async tasks have been created otherwise there could be tasks queued that are unpatched, and thus do not respect nested loops. An example of an unpatched task can be seen in the original issue: ``` <Task pending coro=<HTTP1ServerConnection._server_request_loop() running at /apps/python3/lib/python3.7/site-packages/tornado/http1connection.py:823> ``` which originates from Tornado. A similar issue was reported in `nest-asyncio`: erdewit/nest_asyncio#22 where the solution is to call `apply` on import so that unpatched tasks do not get created.
This was referenced Nov 3, 2021
kevin-bates
approved these changes
Nov 5, 2021
| So we must call `nest_asyncio.apply()` method as early as possible. It | ||
| is preferable to do this in the consuming application rather than the | ||
| `jupyter_client` as it is a global patch and would impact all consumers | ||
| rather than just the ones that rely on synchronous kernel behavior. |
|
@minrk Are you able to take a look? |
|
Thanks! |
yuvipanda
added a commit
to 2i2c-org/utexas-image
that referenced
this pull request
Apr 8, 2022
Brings in jupyter/notebook#6221 to potentially fix 2i2c-org/infrastructure#1170
This was referenced Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #6164
nest_asynciomust be applied before any async tasks have been createdotherwise there could be tasks queued that are unpatched, and thus do
not respect nested loops. An example of an unpatched task can be seen in
the original issue:
which originates from Tornado.
A similar issue was reported in
nest-asyncio: erdewit/nest_asyncio#22where the solution is to call
applyon import so that unpatched tasksdo not get created.