Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3218 #6108

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Fix issue #3218 #6108

merged 2 commits into from
Jul 28, 2021

Conversation

Nazeeh21
Copy link
Contributor

@Nazeeh21 Nazeeh21 commented Jul 21, 2021

Earlier, on route localhost/tree/docs the word "running" appearing next to the file name of the new notebook was failing the color contrast.

Before fixing
Screenshot from 2021-07-21 16-06-26

After fixing
Screenshot from 2021-07-21 16-13-03

**On route localhost/tree#running (a new notebook is running) kernel-name wasn't too dark.

Before fixing
Screenshot from 2021-07-21 16-07-03

After fixing
Screenshot from 2021-07-21 16-14-38

For new notebook, on route http://localhost/notebooks/docs/Untitled.ipynb the contrast for kernel_indicator was failing.

Before fixing
Screenshot from 2021-07-21 16-15-17

After fixing
Screenshot from 2021-07-21 16-15-04

Fixes #3218

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Nazeeh21 - the screenshots are greatly appreciated, these changes look good to me - thank you!

@Nazeeh21
Copy link
Contributor Author

@kevin-bates thanks for approving the changes 😃 and for all your support. Looking forward to my PR getting merged.

@kevin-bates
Copy link
Member

Hi @Nazeeh21 - in speaking with some colleagues about his PR - which looks good, they suggested that comments indicating that the particular lines were updated for the purpose of accessibility be added, perhaps something like // accessibility improvement? Would you mind updating the PR with those?

(Sorry for the delay in getting back, I just realized that I had never submitted a comment similar to this one a couple of days ago.)

@Nazeeh21
Copy link
Contributor Author

Nazeeh21 commented Jul 28, 2021

Sure, I will add // accessibility improvement before every line changed in this PR. Also not an issue for this. 😊

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @Nazeeh21!

@kevin-bates kevin-bates merged commit 94ac6d7 into jupyter:master Jul 28, 2021
@blink1073 blink1073 added the bug label Aug 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility color contrast issues in style.min.css
4 participants