Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum tornado version #5933

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

kevin-bates
Copy link
Member

As noted in #5920, the fix for #5908 introduces a requirement on tornado 6.0. Since #5907 also prefers tornado 6.1 (although doesn't require it), we might as well bump things to 6.1.

Fixes #5920

@lresende lresende merged commit 245ca66 into jupyter:master Jan 11, 2021
@kevin-bates kevin-bates deleted the bump-min-tornado branch January 11, 2021 16:51
@blink1073 blink1073 added this to the 6.2 milestone Mar 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tornado 5.X doesn't have required WebsocketProtocol13.is_closing() method
3 participants