Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for Check in zh_CN #5730

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Fix typo for Check in zh_CN #5730

merged 3 commits into from
Sep 5, 2020

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Sep 4, 2020

检查(check) and 检出(check out) sound similar, but their meaning is different. In this context, it should be 检查.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @bdbai .

Since I don't read Chinese I placed the two strings in google translate and see that the phrase:

, please check out the network connection... and the service configuration.

becomes:

, please check the network connection... and the service configuration.

(sans 'out') - which I agree is better - although google translate is certainly not definitive.

I'm curious if the ellipses ('...') are necessary? I'm approving anyway, just curious.

@bdbai
Copy link
Contributor Author

bdbai commented Sep 4, 2020

@kevin-bates thanks for approval!

I'm curious if the ellipses ('...') are necessary? I'm approving anyway, just curious.

I don't think the ellipses here are necessary. Actually they give me a sense of uncertainty or hesitation, just like how we feel when they appear in English.

@kevin-bates
Copy link
Member

kevin-bates commented Sep 4, 2020

@bdbai - would it make sense to go ahead and remove the ellipses since that hesitation seems unnecessary here?

@bdbai
Copy link
Contributor Author

bdbai commented Sep 5, 2020

@kevin-bates done. There are many more ellipses in this translation. Do you think it is necessary to remove them as well?

@kevin-bates
Copy link
Member

Thank you for the update and offer. It looks like many of the remaining ellipses are trailing - where hesitation is appropriate (e.g., "Restoring to checkpoint..."), but I listed the two additional translations where the English string does not have ellipses while the translation does. If you could review these, that would be greatly appreciated...

@bdbai
Copy link
Contributor Author

bdbai commented Sep 5, 2020

Sorry for the late reply because I am currently on a trip.

While reviewing other phrases, I also found some flaws in this translate, such as wrong usage of half-width punctuation (should be full width for Chinese sentences) and lack of spaces between Chinese characters and English or numbers. However, they are out of the scope of this issue. Would you mind my opening another issue after fixing them?

@kevin-bates
Copy link
Member

That sounds like the right approach - thank you.

@kevin-bates kevin-bates merged commit 5af2343 into jupyter:master Sep 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants