Add keyboard shortcuts to menu dropdowns #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
approved these changes
Jun 12, 2020
Nelyus
force-pushed
the
add-keyboard-shortcuts-to-menu-dropdowns
branch
from
0e17c45
to
ab74efb
Compare
render keyboard shortcuts from KeyboardManager
lmazardo
force-pushed
the
add-keyboard-shortcuts-to-menu-dropdowns
branch
from
ab74efb
to
98f6464
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the work of @aaronmyatt in #2968, this PR fixes #2759.
Fix was all about adding a missing CSS rule regarding word wrapping specifically for
kbdtag.We (see below) tested the fix on many OS & browsers:
As a side note, this PR is a contribution from mob-programming involving : @CadiChris, @garaud, @klock, @limdhuul, @lmazardo, @mikaelletang, @murlock, @Nelyus, @pgrange