Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable check_origin on gateway websocket communication #5471

Merged
merged 1 commit into from
May 25, 2020

Conversation

kevin-bates
Copy link
Member

This is a port of the same change in NB2KG (PR 22).

Fixes #5460

This is a port of the same change in NB2KG (PR 22).

Fixes jupyter#5460

Co-authored-by: Dylan <dylan.yi@icloud.com>
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 6.1 milestone May 25, 2020
@blink1073 blink1073 merged commit 66ad3f4 into jupyter:master May 25, 2020
@kevin-bates kevin-bates deleted the gateway-check-origin branch May 26, 2020 21:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_origin() method for gateway based websocket communication
2 participants