Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert notifications JS test to selenium #5455

Merged
merged 2 commits into from
May 21, 2020
Merged

Convert notifications JS test to selenium #5455

merged 2 commits into from
May 21, 2020

Conversation

nfelger
Copy link
Contributor

@nfelger nfelger commented May 17, 2020

No description provided.

@nfelger nfelger mentioned this pull request May 17, 2020
Closed
blink1073
blink1073 approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@blink1073 blink1073 added this to the 6.1 milestone May 21, 2020
@blink1073 blink1073 merged commit d84faae into jupyter:master May 21, 2020
@nfelger nfelger deleted the issue-3335-notifications branch May 21, 2020 08:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
component:Notebook status:resolved-locked
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nfelger @blink1073